Skip to content

Issue 1748 stress induced diffusion - #1797

Merged
rtimms merged 9 commits into
developfrom
issue-1748-stress-induced-diffusion
Nov 12, 2021
Merged

rtimms merged 9 commits into
developfrom
issue-1748-stress-induced-diffusion

Conversation

@rtimms

@rtimms rtimms commented Nov 10, 2021 •

Copy link
Copy Markdown
Contributor

Description

Add a separate "stress-induced diffusion" model option. Previously this effect was hard-coded into the parameters when the user selected any of the "particle mechanics" options other than "none".

Fixes #1748

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms
rtimms marked this pull request as draft November 10, 2021 15:54
@rtimms
rtimms marked this pull request as ready for review November 10, 2021 16:30

@valentinsulzer valentinsulzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@codecov

codecov Bot commented Nov 11, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #1797 (58922b5) into develop (6e887ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1797   +/-   ##
========================================
  Coverage    99.24%   99.24%           
========================================
  Files          343      344    +1     
  Lines        18983    19037   +54     
========================================
+ Hits         18840    18894   +54     
  Misses         143      143           
Impacted Files Coverage Δ
...s/full_battery_models/lithium_ion/newman_tobias.py 100.00% <ø> (ø)
...bamm/models/full_battery_models/lithium_ion/spm.py 100.00% <ø> (ø)
pybamm/models/submodels/base_submodel.py 100.00% <ø> (ø)
...m/models/full_battery_models/base_battery_model.py 99.71% <100.00%> (+<0.01%) ⬆️
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <100.00%> (ø)
pybamm/models/standard_variables.py 100.00% <100.00%> (ø)
pybamm/models/submodels/particle/base_particle.py 100.00% <100.00%> (ø)
...els/submodels/particle/no_distribution/__init__.py 100.00% <100.00%> (ø)
...submodels/particle/no_distribution/base_fickian.py 100.00% <100.00%> (ø)
...dels/particle/no_distribution/fickian_diffusion.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e887ae...58922b5. Read the comment docs.

@rtimms
rtimms merged commit b7c2ae6 into develop Nov 12, 2021
@rtimms
rtimms deleted the issue-1748-stress-induced-diffusion branch November 12, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stress-induced diffusion should be optional

2 participants