Repository navigation
Issue 1748 stress induced diffusion - #1797
Merged
Merged
Conversation
added 3 commits
November 10, 2021 11:27
rtimms
marked this pull request as draft
November 10, 2021 15:54
rtimms
marked this pull request as ready for review
November 10, 2021 16:30
Codecov Report
@@ Coverage Diff @@
## develop #1797 +/- ##
========================================
Coverage 99.24% 99.24%
========================================
Files 343 344 +1
Lines 18983 19037 +54
========================================
+ Hits 18840 18894 +54
Misses 143 143
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a separate "stress-induced diffusion" model option. Previously this effect was hard-coded into the parameters when the user selected any of the "particle mechanics" options other than "none".
Fixes #1748
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: