Issue 1903 power - #1917
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1917 +/- ##
========================================
Coverage 99.32% 99.32%
========================================
Files 346 346
Lines 19002 19058 +56
========================================
+ Hits 18874 18930 +56
Misses 128 128
Continue to review full report at Codecov.
|
rtimms
approved these changes
Feb 7, 2022
rtimms
left a comment
rtimms
left a comment
Contributor
There was a problem hiding this comment.
thanks @tinosulzer looks good!
| @@ -5,46 +5,41 @@ | |||
| import pybamm | |||
Contributor
There was a problem hiding this comment.
need to change the example script back
| "resistance", | ||
| "differential resistance", | ||
| "explicit resistance", | ||
| "CCCV", |
Contributor
There was a problem hiding this comment.
the CCCV option isn't listed in the docs
| def get_coupled_variables(self, variables): | ||
| param = self.param | ||
|
|
||
| # Current is given as applied power divided by voltage |
Contributor
There was a problem hiding this comment.
voltage divided by resistance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds more operating modes for power and resistance control.
The explicit models can only be used with DFN without surface form, so it's not possible to completely eliminate algebraic equations using that (but it can be done using the differential models)
Fixes #1903
Fixes #1691
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: