Repository navigation
add ocp as a separate submodel - #2094
Merged
Merged
Conversation
rtimms
approved these changes
Jun 21, 2022
rtimms
left a comment
Contributor
There was a problem hiding this comment.
thanks @tinosulzer looks good!
rtimms
reviewed
Jun 21, 2022
| self.set_crack_submodel() | ||
| self.set_active_material_submodel() | ||
| self.set_transport_efficiency_submodels() | ||
| self.set_convection_submodel() |
Contributor
There was a problem hiding this comment.
think you need to move the defn of set_convection_submodel into this file from SPM, SPMe, DFN
rtimms
reviewed
Jun 21, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2094 +/- ##
========================================
Coverage 99.38% 99.38%
========================================
Files 352 355 +3
Lines 19289 19302 +13
========================================
+ Hits 19170 19183 +13
Misses 119 119
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds OCV as a submodel. Currently there is only one kind of submodel, but #2073 will be adding the current sigmoid.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: