Skip to content

add ocp as a separate submodel - #2094

Merged
valentinsulzer merged 9 commits into
developfrom
ocv-submodel
Jun 28, 2022
Merged

valentinsulzer merged 9 commits into
developfrom
ocv-submodel

Conversation

@valentinsulzer

Copy link
Copy Markdown
Member

Description

Adds OCV as a submodel. Currently there is only one kind of submodel, but #2073 will be adding the current sigmoid.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer
valentinsulzer requested a review from rtimms June 8, 2022 06:50

@rtimms rtimms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer looks good!

self.set_crack_submodel()
self.set_active_material_submodel()
self.set_transport_efficiency_submodels()
self.set_convection_submodel()

@rtimms rtimms Jun 21, 2022 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think you need to move the defn of set_convection_submodel into this file from SPM, SPMe, DFN

@rtimms rtimms left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, actually it looks like this has broken the half-cell models?

@codecov

codecov Bot commented Jun 28, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #2094 (596e318) into develop (4ec415d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2094   +/-   ##
========================================
  Coverage    99.38%   99.38%           
========================================
  Files          352      355    +3     
  Lines        19289    19302   +13     
========================================
+ Hits         19170    19183   +13     
  Misses         119      119           
Impacted Files Coverage Δ
...ybamm/models/submodels/interface/base_interface.py 100.00% <ø> (ø)
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
pybamm/__init__.py 100.00% <100.00%> (ø)
...l_battery_models/lead_acid/base_lead_acid_model.py 100.00% <100.00%> (ø)
...ybamm/models/full_battery_models/lead_acid/full.py 100.00% <100.00%> (ø)
...dels/full_battery_models/lead_acid/higher_order.py 98.14% <100.00%> (+0.01%) ⬆️
...ybamm/models/full_battery_models/lead_acid/loqs.py 100.00% <100.00%> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py 100.00% <100.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <100.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/spm.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fd8cf3...596e318. Read the comment docs.

@valentinsulzer
valentinsulzer merged commit 8465069 into develop Jun 28, 2022
@valentinsulzer
valentinsulzer deleted the ocv-submodel branch June 28, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants