#2098 change averaging for SPMe+SR

[brosaplanella]

Description

Changed the averaging for SEI, lithium plating and porosity submodels for SPM and SPMe. Wait to merge until the citation is updated.

Fixes #2098

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #2099 (d7edf6f) into develop (9856785) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2099   +/-   ##
========================================
  Coverage    99.35%   99.35%           
========================================
  Files          347      347           
  Lines        19241    19251   +10     
========================================
+ Hits         19117    19127   +10     
  Misses         124      124           

Impacted Files	Coverage Δ
...ls/LGM50_ORegan2022/aluminium_heat_capacity_CRC.py	100.00% <ø> (ø)
...cells/LGM50_ORegan2022/copper_heat_capacity_CRC.py	100.00% <ø> (ø)
...GM50_ORegan2022/copper_thermal_conductivity_CRC.py	100.00% <ø> (ø)
...graphite_ORegan2022/graphite_LGM50_ocp_Chen2020.py	100.00% <ø> (ø)
...lectrodes/nmc_ORegan2022/nmc_LGM50_ocp_Chen2020.py	100.00% <ø> (ø)
...amm/models/full_battery_models/lithium_ion/spme.py	100.00% <ø> (ø)
...Regan2022/graphite_LGM50_diffusivity_ORegan2022.py	100.00% <100.00%> (ø)
...electrolyte_exchange_current_density_ORegan2022.py	100.00% <100.00%> (ø)
...n2022/graphite_LGM50_entropic_change_ORegan2022.py	100.00% <100.00%> (ø)
...gan2022/graphite_LGM50_heat_capacity_ORegan2022.py	100.00% <100.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9856785...d7edf6f. Read the comment docs.

[valentinsulzer]

I have a few questions about this, let's go over it in the Monday meeting

[brosaplanella]

I have a few questions about this, let's go over it in the Monday meeting

I will miss the next two meetings, but there's no rush on this so happy to chat about when I am back.

[valentinsulzer]

Looks good, just the change discussed in meeting

[brosaplanella]

Note that I have updated ORegan2021 to ORegan2022 now that it has been published, hence all the files modified.

[valentinsulzer]

Thanks, looks good!

[valentinsulzer]

shouldn't it be true for SPM? I think it won't make a difference to results, but will be faster

[brosaplanella]

I think I have fixed it now, take a look. It is a bit messy at the moment, hopefully will be clearer once we have derived the SPMe for cracks and loss of active material submodels.

[valentinsulzer]

merge whenever ready