Skip to content

fix bug in callbacks - #2213

Merged
valentinsulzer merged 2 commits into
developfrom
callback-bug
Aug 3, 2022
Merged

fix bug in callbacks#2213
valentinsulzer merged 2 commits into
developfrom
callback-bug

Conversation

@valentinsulzer

Copy link
Copy Markdown
Member

Description

Fix a bug in callbacks for the Simulation class that was displaying the wrong error for experiments.

I keep fixing this in different branches, so hopefully doing it in its own branch will get in merged quicker.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@brosaplanella brosaplanella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Add an entry to CHANGELOG before merging.

@codecov

codecov Bot commented Aug 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2213 (cb98ea3) into develop (59c99b2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2213      +/-   ##
===========================================
- Coverage    99.36%   99.36%   -0.01%     
===========================================
  Files          355      355              
  Lines        19514    19511       -3     
===========================================
- Hits         19390    19387       -3     
  Misses         124      124              
Impacted Files Coverage Δ
pybamm/callbacks.py 100.00% <100.00%> (ø)
pybamm/simulation.py 98.83% <100.00%> (+<0.01%) ⬆️
pybamm/solvers/casadi_solver.py 98.25% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@valentinsulzer
valentinsulzer merged commit aa5f85d into develop Aug 3, 2022
@valentinsulzer
valentinsulzer deleted the callback-bug branch August 3, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants