fix bug in callbacks - #2213
Merged
Merged
Conversation
brosaplanella
approved these changes
Aug 3, 2022
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks! Add an entry to CHANGELOG before merging.
Codecov Report
@@ Coverage Diff @@
## develop #2213 +/- ##
===========================================
- Coverage 99.36% 99.36% -0.01%
===========================================
Files 355 355
Lines 19514 19511 -3
===========================================
- Hits 19390 19387 -3
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in callbacks for the Simulation class that was displaying the wrong error for experiments.
I keep fixing this in different branches, so hopefully doing it in its own branch will get in merged quicker.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: