Repository navigation
Composite release parameters - #2248
Merged
Merged
Conversation
…-release-parameters
…-release-parameters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
valentinsulzer
changed the base branch from
develop
to
variable-renaming-for-composite-release
August 18, 2022 16:13
valentinsulzer
changed the base branch from
variable-renaming-for-composite-release
to
develop
August 19, 2022 00:05
Codecov Report
@@ Coverage Diff @@
## develop #2248 +/- ##
===========================================
+ Coverage 99.36% 99.38% +0.01%
===========================================
Files 357 359 +2
Lines 19514 19821 +307
===========================================
+ Hits 19391 19699 +308
+ Misses 123 122 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
brosaplanella
approved these changes
Aug 23, 2022
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks @tinosulzer! Just a few minor questions and comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some changes in preparation for the composite release.
No silicon parameters are added, this PR just tests with a two phase graphite/graphite system
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: