Issue 2382 simulation only - #2395
Merged
Merged
Conversation
valentinsulzer
marked this pull request as draft
October 21, 2022 17:58
Codecov ReportBase: 99.72% // Head: 99.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2395 +/- ##
===========================================
- Coverage 99.72% 99.71% -0.01%
===========================================
Files 268 267 -1
Lines 20153 20044 -109
===========================================
- Hits 20097 19987 -110
- Misses 56 57 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
valentinsulzer
marked this pull request as ready for review
October 24, 2022 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reformat Simulation and Experiment classes to process models more cleanly and efficiently.
Progress towards #2322 but not yet complete
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: