More simplifications#2443
Conversation
Codecov ReportBase: 99.72% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2443 +/- ##
========================================
Coverage 99.72% 99.72%
========================================
Files 258 258
Lines 19184 19211 +27
========================================
+ Hits 19131 19158 +27
Misses 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…into more-simplifications
|
|
||
| ## Optimizations | ||
|
|
||
| - Added more rules for simplifying expressions, especially around Concatenations. Also, meshes constructed from multiple domains are now memoized ([#2443](https://github.com/pybamm-team/PyBaMM/pull/2443)) |
There was a problem hiding this comment.
| - Added more rules for simplifying expressions, especially around Concatenations. Also, meshes constructed from multiple domains are now memoized ([#2443](https://github.com/pybamm-team/PyBaMM/pull/2443)) | |
| - Added more rules for simplifying expressions, especially around Concatenations. Also, meshes constructed from multiple domains are now memorized ([#2443](https://github.com/pybamm-team/PyBaMM/pull/2443)) |
There was a problem hiding this comment.
This refers to memoization https://en.wikipedia.org/wiki/Memoization, but I will change it to "cached"
There was a problem hiding this comment.
Oops, didn't know that, sorry! If it is a word, happy to keep it as it is.
Description
Still more simplifications
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: