Skip to content

Conversation

@valentinsulzer
Copy link
Member

Description

Fixed some bugs related to processing FunctionParameter to Interpolant
Interpolants created from parameter data are now "linear" by default (was "cubic")

Fixes #2264
Fixes #2491

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (90b2753) compared to base (4f233b0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2494      +/-   ##
===========================================
- Coverage    99.72%   99.72%   -0.01%     
===========================================
  Files          257      257              
  Lines        18973    18961      -12     
===========================================
- Hits         18920    18908      -12     
  Misses          53       53              
Impacted Files Coverage Δ
pybamm/solvers/casadi_algebraic_solver.py 100.00% <ø> (ø)
pybamm/solvers/idaklu_solver.py 99.06% <ø> (ø)
pybamm/solvers/jax_solver.py 96.77% <ø> (ø)
pybamm/solvers/scikits_dae_solver.py 98.63% <ø> (ø)
pybamm/solvers/scikits_ode_solver.py 97.56% <ø> (ø)
pybamm/solvers/scipy_solver.py 100.00% <ø> (ø)
...s/full_battery_models/lithium_ion/electrode_soh.py 100.00% <100.00%> (ø)
pybamm/parameters/parameter_values.py 100.00% <100.00%> (ø)
pybamm/solvers/base_solver.py 100.00% <100.00%> (ø)
pybamm/solvers/casadi_solver.py 99.66% <100.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good!

@valentinsulzer valentinsulzer merged commit 41ad13a into develop Nov 28, 2022
@valentinsulzer valentinsulzer deleted the issue-2491-parameter-events branch November 28, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: pybamm.expression_tree.exceptions.SolverError: No value provided for input 'x' ElectrodeSOH raises an error if OCP is data

3 participants