-
-
Notifications
You must be signed in to change notification settings - Fork 617
Issue 2760 step #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2760 step #2773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Happy to merge once tests pass
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2773 +/- ##
========================================
Coverage 99.68% 99.68%
========================================
Files 272 272
Lines 19017 19024 +7
========================================
+ Hits 18958 18965 +7
Misses 59 59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Description
Adds offset to the start of steps which follow from previous solution. This avoid duplicate time in solution and ensures that concatenations of steps (/cycles) have the same length as the whole cycle (/solution)
Fixes #2760
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
$ python run-tests.py --doctest
You can run unit and doctests together at once, using
$ python run-tests.py --quick
.Further checks: