Skip to content

add new esoh variables from dVdQ paper#2807

Merged
valentinsulzer merged 2 commits intodevelopfrom
dvdq
Mar 26, 2023
Merged

add new esoh variables from dVdQ paper#2807
valentinsulzer merged 2 commits intodevelopfrom
dvdq

Conversation

@valentinsulzer
Copy link
Member

Description

https://arxiv.org/abs/2303.07088

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c19fbed) 99.68% compared to head (6bbf8ea) 99.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2807   +/-   ##
========================================
  Coverage    99.68%   99.69%           
========================================
  Files          272      272           
  Lines        19027    19035    +8     
========================================
+ Hits         18968    18976    +8     
  Misses          59       59           
Impacted Files Coverage Δ
pybamm/input/parameters/lithium_ion/NCA_Kim2011.py 100.00% <100.00%> (ø)
...s/full_battery_models/lithium_ion/electrode_soh.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit c78bed2 into develop Mar 26, 2023
@valentinsulzer valentinsulzer deleted the dvdq branch March 26, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants