Skip to content

save step and cycle number from a solution#2931

Merged
valentinsulzer merged 4 commits intodevelopfrom
save-cycle-and-step-number
May 9, 2023
Merged

save step and cycle number from a solution#2931
valentinsulzer merged 4 commits intodevelopfrom
save-cycle-and-step-number

Conversation

@valentinsulzer
Copy link
Member

Description

I keep doing this manually and it might be useful here instead

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (1928b19) 99.68% compared to head (8dda652) 99.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2931      +/-   ##
===========================================
+ Coverage    99.68%   99.71%   +0.02%     
===========================================
  Files          273      273              
  Lines        18997    19002       +5     
===========================================
+ Hits         18938    18947       +9     
+ Misses          59       55       -4     
Impacted Files Coverage Δ
...bamm/expression_tree/operations/evaluate_python.py 99.29% <ø> (ø)
pybamm/solvers/jax_bdf_solver.py 98.89% <100.00%> (+0.85%) ⬆️
pybamm/solvers/solution.py 100.00% <100.00%> (ø)
pybamm/util.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit 1b178bb into develop May 9, 2023
@valentinsulzer valentinsulzer deleted the save-cycle-and-step-number branch May 9, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants