-
-
Notifications
You must be signed in to change notification settings - Fork 703
Issue 2901 parameters csv #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2959 +/- ##
===========================================
- Coverage 99.71% 99.70% -0.01%
===========================================
Files 273 245 -28
Lines 19032 18628 -404
===========================================
- Hits 18977 18573 -404
Misses 55 55
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! You need to add to the CHANGELOG before merging.
Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
…BaMM into issue-2901-parameters-csv
Description
In recent versions of PyBaMM, we recommend using python files to specify parameter sets (as opposed to csv files in early versions). This PR removes all the functionality that was included to make loading from csv files possible. Loading from csv files is no longer possible, and Python files should now always be used instead.
Fixes #2901
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all$ python run-tests.py --doctestYou can run unit and doctests together at once, using
$ python run-tests.py --quick.Further checks: