X full thermal

[rtimms]

Description

Update the "x-full" thermal model to account for edge/tab cooling and account for the current collector volumetric heat capacity. The existing "x-full" model solves for T(x) in the electrode/separator/electrode sandwich only and only accounts for cooling from the two large faces of a pouch cell.

Because of the way current collector domains are currently set up (only ever used in an x-averaged sense, with no distinction between negative and positive domains), we can't solve the full PDE for heat conservation across the neg. c.c./electrode/separator/electrode/pos. c.c. stack. In this PR we:

1. Add ODEs for the lumped current collector temperatures, which account for cooling from the large face of the pouch, the edges, and the tabs, and enforce continuity of flux at the electrode/current collector interface.
2. Adjust the boundary conditions for the PDE for the temperature in the electrode/separator/electrode sandwich to enforce continuity of temperature at the electrode/current collector interface
3. Add bulk sink terms to account for cooling from the cell edges

TODO: update the thermal models notebook to reflect these changes.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all
• The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ea7e00c) 99.71% compared to head (e76ca26) 99.71%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3042   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18824    18856   +32     
========================================
+ Hits         18770    18802   +32     
  Misses          54       54           

Files Changed	Coverage Δ
pybamm/models/submodels/thermal/base_thermal.py	100.00% <ø> (ø)
pybamm/models/submodels/thermal/lumped.py	100.00% <ø> (ø)
...mal/pouch_cell/pouch_cell_2D_current_collectors.py	100.00% <ø> (ø)
...m/models/full_battery_models/base_battery_model.py	99.76% <100.00%> (ø)
pybamm/models/submodels/thermal/x_full.py	100.00% <100.00%> (ø)
pybamm/parameters/lead_acid_parameters.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brosaplanella]

Looks good, happy to merge once tests pass

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB