Repository navigation
#3161 add emperical hysteresis for exchange-current and diffusivity - #3194
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3194 +/- ##
========================================
Coverage 99.71% 99.71%
========================================
Files 248 248
Lines 18764 18801 +37
========================================
+ Hits 18710 18747 +37
Misses 54 54
☔ View full report in Codecov by Sentry. |
valentinsulzer
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds options for "diffusivity" and "exchange-current density" to enable the models to account for hysteresis in these parameters using an empirical model in the same way we currently handle hysteresis in the open-circuit potential. The options can be "single" (this is the default behaviour where a single value/function is provided for each of the diffusivity and exchange current density in each electrode) or "current sigmoid" (where users give a lithiation and delithiation parameter, which are switched between depending on the sign of the current).
Fixes #3161
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all$ python run-tests.py --doctestYou can run unit and doctests together at once, using
$ python run-tests.py --quick.Further checks: