Improve memory use in experiments - #3261
Merged
Merged
Conversation
…1-improve-memory-experiments
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3261 +/- ##
========================================
Coverage 99.55% 99.55%
========================================
Files 253 253
Lines 19553 19558 +5
========================================
+ Hits 19466 19471 +5
Misses 87 87
☔ View full report in Codecov by Sentry. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rtimms
approved these changes
Sep 15, 2023
rtimms
left a comment
Contributor
There was a problem hiding this comment.
thanks @brosaplanella looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve memory use in experiments by redefining what steps are unique. Two steps are considered the same if
type,value,terminationandtemperatureare the same, as these are the variables used when processing the model. The remaining variables are only used when running the model and can be passed as inputs. I have also defined abasic_reprwhich returns a representation with only those variables, while__repr__returns a representation with all the variables.Fixes #3081
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: