General thermal bcs

[rtimms]

Description

Fixes some bugs with the pouch cell thermal models that were introduced when we switched from a dimensionless to a dimensional formulation. Specifically, this adds a missing thermal conductivity (in the previous formulation the dimensionless effective conductivity was 1 due to the choice of non-dimensionalisation, which is why it was missed).

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

Patch coverage: 94.17% and project coverage change: +0.02% 🎉

Comparison is base (7cba890) 99.55% compared to head (8af2430) 99.57%.
Report is 30 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3330      +/-   ##
===========================================
+ Coverage    99.55%   99.57%   +0.02%     
===========================================
  Files          253      253              
  Lines        19553    19571      +18     
===========================================
+ Hits         19466    19488      +22     
+ Misses          87       83       -4     

Files Changed	Coverage Δ
...bamm/expression_tree/operations/evaluate_python.py	99.29% <ø> (ø)
...mal/pouch_cell/pouch_cell_2D_current_collectors.py	100.00% <ø> (ø)
pybamm/solvers/solution.py	100.00% <ø> (ø)
pybamm/solvers/jax_solver.py	90.69% <79.31%> (-6.08%)	⬇️
pybamm/experiment/experiment.py	100.00% <100.00%> (ø)
...dels/submodels/current_collector/potential_pair.py	100.00% <100.00%> (ø)
...mal/pouch_cell/pouch_cell_1D_current_collectors.py	100.00% <100.00%> (ø)
pybamm/parameters/bpx.py	99.49% <100.00%> (+4.73%)	⬆️
pybamm/parameters/lithium_ion_parameters.py	100.00% <100.00%> (ø)
pybamm/parameters/thermal_parameters.py	100.00% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brosaplanella]

Looks good, thanks!