Update quickplot to catch empty lists - #3359
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3359 +/- ##
===========================================
- Coverage 99.57% 99.56% -0.02%
===========================================
Files 253 253
Lines 19571 19555 -16
===========================================
- Hits 19488 19470 -18
- Misses 83 85 +2
☔ View full report in Codecov by Sentry. |
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Looks good, just a couple of things before approving. Can you address the small comment on the test and add an entry to the CHANGELOG?
brosaplanella
approved these changes
Sep 21, 2023
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Can you commit the suggested change? Happy to merge afterwards
Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Member
|
@all-contributors please add @kratman for tests |
Contributor
|
I've put up a pull request to add @kratman! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added some error handling for QuickPlot when an empty list is passed as the first argument.
Changes:
QuickPlot([])Fixes #3172
Type of change
Minor bug fix for catching empty input lists.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: