Rename "positive electrode diffusivity" to "positive particle diffusivity" - #3624
Merged
kratman merged 16 commits intoJan 27, 2024
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3624 +/- ##
========================================
Coverage 99.59% 99.59%
========================================
Files 257 257
Lines 20796 20802 +6
========================================
+ Hits 20712 20718 +6
Misses 84 84 ☔ View full report in Codecov by Sentry. |
5 tasks
adityaraute
approved these changes
Dec 25, 2023
julian-evers
requested review from
a team,
DrSOKane,
Saransh-cpp,
TomTranter,
agriyakhetarpal,
arjxn-py,
brosaplanella,
kratman,
rtimms and
valentinsulzer
as code owners
January 22, 2024 17:01
brosaplanella
approved these changes
Jan 25, 2024
brosaplanella
left a comment
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Looks good to me, just a small comment on the CHANGELOG. You should probably add a line in the breaking changes too.
kratman
requested changes
Jan 26, 2024
kratman
left a comment
kratman
left a comment
Contributor
There was a problem hiding this comment.
Duplicate change log entry
kratman
approved these changes
Jan 27, 2024
This was referenced May 7, 2024
kratman
added a commit
that referenced
this pull request
May 22, 2024
* removes breaking change from electrode diffusivity -> particle diffusivity * Add conditional entry for base_solver inputs recreation * fix: incorrect depreciated parameter translation, moves conversion to ParameterValues staticmethod Fixes an incorrect conversion of electrode diffusivity to particle diffusivity, Updates the corresponding test to ensure FuzzyDict.__getitem__ functions correctly, Adds conversion and checks to BaseSolver inputs object, * Add changelog entry --------- Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this pull request
Aug 12, 2024
…vity" (pybamm-team#3624) * merge_conflicts * merge_conflicts_ * update_pr_number * rename_empirical_hysteresis * style: pre-commit fixes * style: pre-commit fixes * update changelog * fix bpx * style: pre-commit fixes * update changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this pull request
Aug 12, 2024
* removes breaking change from electrode diffusivity -> particle diffusivity * Add conditional entry for base_solver inputs recreation * fix: incorrect depreciated parameter translation, moves conversion to ParameterValues staticmethod Fixes an incorrect conversion of electrode diffusivity to particle diffusivity, Updates the corresponding test to ensure FuzzyDict.__getitem__ functions correctly, Adds conversion and checks to BaseSolver inputs object, * Add changelog entry --------- Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "electrode diffusivity" parameter have been renamed to "particle diffusivity". parameter_values["Positive electrode diffusivity"] returns "Positive particle diffusivity" with a deprecation warning.
Fixes #3229
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: