#3690 fix issue with skipped steps

[rtimms]

Description

Fixed a bug where if the first step(s) in a cycle are skipped then the cycle solution started from the model's initial conditions instead of from the last state of the previous cycle.

Fixes #3690

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[rtimms]

@Saransh-cpp this is a bug fix that should go into 24.1

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf2203c) 99.59% compared to head (1baae8c) 99.59%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3708   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          258      258           
  Lines        20796    20798    +2     
========================================
+ Hits         20711    20713    +2     
  Misses          85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinsulzer]

Looks good thanks

[valentinsulzer]

if this is going into 24.1 this needs to move

[rtimms]

what’s the process? should i just manually make a new section for the next release candidate?

[Saransh-cpp]

You can leave it as it is. The workflow will automatically create a v24.1rc1 section with the new changes.

[rtimms]

cool. where/when should this be merged?