refactor experiment steps to allow customization by user#3835
Merged
Conversation
valentinsulzer
requested review from
a team,
DrSOKane,
Saransh-cpp,
TomTranter,
agriyakhetarpal,
arjxn-py,
brosaplanella,
kratman,
martinjrobins and
rtimms
as code owners
February 24, 2024 19:33
valentinsulzer
marked this pull request as draft
February 24, 2024 19:33
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3835 +/- ##
========================================
Coverage 99.60% 99.60%
========================================
Files 259 259
Lines 21275 21331 +56
========================================
+ Hits 21191 21247 +56
Misses 84 84 ☔ View full report in Codecov by Sentry. |
valentinsulzer
marked this pull request as ready for review
March 7, 2024 21:38
rtimms
approved these changes
Mar 26, 2024
kratman
reviewed
Mar 26, 2024
…M into issue-3530-custom-step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor experiment steps to move the logic for processing the step from the Simulation class to the Step class.
This allows users to create custom steps by writing their own logic, using the
CustomStepExplicitorCustomStepImplicitclasses.Fixes #3530
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: