Remove support for python 3.8

[kratman]

Description

Removes support for python 3.8

Fixes #3390

Type of change

This is a breaking change since it reduces support for a python version. On the plus side it reduces the number of CI jobs.

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[kratman]

I merged #3962 into this one to get the tests running faster

[agriyakhetarpal]

Also, I remember that there were some notes that we had added about the JAX solver not being available for Python 3.8, we should be able to remove those too now (can't find where exactly they were in the installation docs)

[kratman]

Also, I remember that there were some notes that we had added about the JAX solver not being available for Python 3.8, we should be able to remove those too now (can't find where exactly they were in the installation docs)

I think I removed them all. I can double check though

[agriyakhetarpal]

Found them, they are in gnu-linux-mac.rst and windows.rst under the "Optional – JaxSolver" headings

[agriyakhetarpal]

Thanks! I'm not aware of the typing stuff but it looks okay to me since pre-commit is passing.

[kratman]

Thanks! I'm not aware of the typing stuff but it looks okay to me since pre-commit is passing.

That was done by pre-commit. I guess it detected that I removed 3.8 support and switched a bunch of stuff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (78b7d25) to head (ed88481).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3961   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          257      257           
  Lines        21196    21198    +2     
========================================
+ Hits         21108    21110    +2     
  Misses          88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.