Reduced the number of docker images by one pybamm:latest#3992
Reduced the number of docker images by one pybamm:latest#3992arjxn-py merged 12 commits intopybamm-team:developfrom
pybamm:latest#3992Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3992 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 257 257
Lines 21245 21245
========================================
Hits 21157 21157
Misses 88 88 ☔ View full report in Codecov by Sentry. |
|
Also, we'll need a CHANGELOG entry about this breaking change, mentioning the removal of the other arguments and asking users to use the |
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
|
Could you do a one final review? |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @santacodes! This looks good to me. I'll leave it up to @arjxn-py to take another look, after which we can merge.
arjxn-py
left a comment
There was a problem hiding this comment.
Looks good @santacodes, just a couple of comments & suggestions below.
|
This one is good to merge too, I'll merge this as soon as tests pass |
|
Sounds good to me |
arjxn-py
left a comment
There was a problem hiding this comment.
Thanks for taking this up @santacodes 🙂
…am#3992) * reduced the image to one * removed build time args and multiple image builds * removed optional solvers from docker docs * Apply suggestions from code review Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * code review suggestions * added breaking change to changelog.md * Update CHANGELOG.md * Apply suggestions from code review --------- Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Description
The
Dockerfileis reduced to include all the solvers by default, the documentation forinstall from source (docker)anddocker.ymlworkflow file have been updated to push only one single docker image taggedpybamm:latestto dockerhub with all the solvers contained in them by default, i.eIDAKLUandJAX.Fixes #3666
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: