Add more idaklu solver options (number 2)#4282
Conversation
|
Replacement for #4249, review was partially done there |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4282 +/- ##
===========================================
- Coverage 99.45% 99.45% -0.01%
===========================================
Files 288 288
Lines 22092 22091 -1
===========================================
- Hits 21972 21971 -1
Misses 120 120 ☔ View full report in Codecov by Sentry. |
martinjrobins
left a comment
There was a problem hiding this comment.
thanks @MarcBerliner, be great to have all these new options in there. I think the main todo left is to update the docstring for the idaklu solver to describe all the new options.
|
I changed |
martinjrobins
left a comment
There was a problem hiding this comment.
looks great, I'm happy with this. Thanks @MarcBerliner
kratman
left a comment
There was a problem hiding this comment.
Codacy still looks like false alarms, just the minor changelog issue
* IDAKLU options updates * format * update defaults and docstrings * Update CHANGELOG.md * Update test_idaklu_solver.py * Move changelog to `Unreleased` * Update CHANGELOG.md --------- Co-authored-by: kratman <kratmandu@gmail.com> Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Description
Adds more user-configurable options to the IDA solver following the list in the IDA guide.
Some code cleanup to enforce early returns.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: