Skip to content

Conversation

@kratman
Copy link
Contributor

@kratman kratman commented Aug 19, 2024

Description

Removes the deprecated install_jax() method

Fixes #4131

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (8057c16) to head (b26c99f).
Report is 202 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4362      +/-   ##
===========================================
- Coverage    99.46%   99.42%   -0.04%     
===========================================
  Files          289      289              
  Lines        22200    22153      -47     
===========================================
- Hits         22081    22026      -55     
- Misses         119      127       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kratman!

@kratman kratman requested a review from Saransh-cpp August 20, 2024 16:08
@kratman kratman self-assigned this Aug 20, 2024
@Saransh-cpp Saransh-cpp self-requested a review August 20, 2024 17:07
@kratman
Copy link
Contributor Author

kratman commented Aug 27, 2024

@Saransh-cpp, @agriyakhetarpal I pull out the has_jax() part for now

@kratman
Copy link
Contributor Author

kratman commented Aug 27, 2024

Coverage failure is unrelated

@kratman kratman dismissed Saransh-cpp’s stale review August 27, 2024 20:34

Part of the code under discussion was removed

@rtimms rtimms merged commit 265dcd6 into pybamm-team:develop Aug 27, 2024
@agriyakhetarpal agriyakhetarpal deleted the fix/removeInstallJax branch August 27, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pybamm_install_jax and references to it

4 participants