Skip to content

Fix IDAKLU segfault with output variables#4379

Merged
kratman merged 1 commit intopybamm-team:developfrom
MarcBerliner:fix-idaklu-output-memory-
Aug 26, 2024
Merged

Fix IDAKLU segfault with output variables#4379
kratman merged 1 commit intopybamm-team:developfrom
MarcBerliner:fix-idaklu-output-memory-

Conversation

@MarcBerliner
Copy link
Copy Markdown
Member

Description

Fixed a memory issue with output variables reported in #4375

Fixes #4375

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (4d391fa) to head (efbed0e).
Report is 203 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4379   +/-   ##
========================================
  Coverage    99.46%   99.46%           
========================================
  Files          289      289           
  Lines        22200    22200           
========================================
  Hits         22081    22081           
  Misses         119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kratman kratman merged commit e78f95a into pybamm-team:develop Aug 26, 2024
@kratman kratman mentioned this pull request Aug 26, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: IDAKLU w/ output variables aborts for repeated simulations

2 participants