Skip to content

Update IDAKLU time stepping in tests and benchmarks#4390

Merged
kratman merged 3 commits intopybamm-team:developfrom
MarcBerliner:update-test/benchmarks
Aug 28, 2024
Merged

Update IDAKLU time stepping in tests and benchmarks#4390
kratman merged 3 commits intopybamm-team:developfrom
MarcBerliner:update-test/benchmarks

Conversation

@MarcBerliner
Copy link
Copy Markdown
Member

Description

This PR updates the IDAKLU tests and benchmarks to use the updated t_eval and t_interp arguments. This will speed up the github actions a bit and better reflect the performance of the IDAKLUSolver in benchmarks.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Optimization (back-end change that speeds up the code)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (ac6c450) to head (c2f6b77).
Report is 200 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4390      +/-   ##
===========================================
- Coverage    99.46%   99.42%   -0.05%     
===========================================
  Files          292      292              
  Lines        22215    22215              
===========================================
- Hits         22097    22087      -10     
- Misses         118      128      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman
Copy link
Copy Markdown
Contributor

kratman commented Aug 28, 2024

Project wide coverage change is just from time conversion routines. It looks like util.py should be reworked a bit in the future. Probably a bunch of the functions can be cleaned up or tested better

@kratman kratman merged commit 5fdee8a into pybamm-team:develop Aug 28, 2024
@kratman kratman deleted the update-test/benchmarks branch August 28, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants