Geometric input params#4665
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4665 +/- ##
===========================================
+ Coverage 99.22% 99.25% +0.02%
===========================================
Files 303 303
Lines 23070 23223 +153
===========================================
+ Hits 22891 23049 +158
+ Misses 179 174 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtimms
reviewed
Jan 2, 2025
8 tasks
rtimms
approved these changes
Jan 2, 2025
Member
|
Sorry, got late to the review, but that's great! Tagging @BradyPlanden as this will be relevant to PyBOP. |
Contributor
Author
|
Do reach out to me if you are interested in using it, it doesn't work with the "out of the box" pybamm models but its relatively straightforward to get it working with custom models |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements a
SymbolicUniform1DSubmesh, which allows for geometric parameters, such as electrode thicknesses and particle sizes to bepybamm.InputParameter's.Fixes #3649
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest(or$ nox -s tests)$ python -m pytest --doctest-plus src(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks: