Skip to content

add post_order#4684

Merged
rtimms merged 3 commits into
developfrom
add-post-order
Dec 17, 2024
Merged

add post_order#4684
rtimms merged 3 commits into
developfrom
add-post-order

Conversation

@rtimms
Copy link
Copy Markdown
Contributor

@rtimms rtimms commented Dec 17, 2024

Description

Add post_order method to symbol to return an iterable that steps through the tree in post-order fashion

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Copy Markdown
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rtimms

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (864388f) to head (0b257a6).
Report is 146 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4684   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          302      302           
  Lines        22880    22883    +3     
========================================
+ Hits         22701    22704    +3     
  Misses         179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtimms rtimms merged commit ae014e2 into develop Dec 17, 2024
@rtimms rtimms deleted the add-post-order branch December 17, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants