Sei composite multiparticle

[aabills]

Description

make sei work with particle size distributions

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python -m pytest (or $ nox -s tests)
• The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (a7253b8) to head (abb8697).
Report is 18 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4693      +/-   ##
===========================================
+ Coverage    99.22%   99.25%   +0.02%     
===========================================
  Files          303      303              
  Lines        23070    23232     +162     
===========================================
+ Hits         22891    23058     +167     
+ Misses         179      174       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rtimms]

thanks @aabills looks good to me, just some commented code that i think can be removed

[kratman]

@rtimms, @aabills The failures are probably all outside of this PR, but this got merged with failing tests.

I am working on the tests though

[aabills]

Should we revert?

Looking at it I don't think it will be this but I think we need to be careful with PR's that mess with submodels, they're just so darn finicky.

[aabills]

How did it get merged? I had it on auto-merge which should wait until checks pass right??

[kratman]

Yeah it is just an issue with auto-merge and our CI. Tests are not required yet

The test failures are string precision, so I am fixing them now. I don't see any failures from your changes, I double checked locally

[aabills]

If auto merge doesn't wait for tests I think we should not let people use it if that's possible

[kratman]

How did it get merged? I had it on auto-merge which should wait until checks pass right??

A lot of tests were not required on PyBaMM because it blocked bot created PRs from merging. I am starting to enforce these things