Update BPX version and make PyBaMM compatible with Pydantic V2#4701
Merged
Conversation
Contributor
Author
|
I expect this to fail until the new BPX release is available. I tested this locally with the BPX release candidate |
rtimms
previously approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4701 +/- ##
===========================================
- Coverage 99.22% 99.22% -0.01%
===========================================
Files 303 303
Lines 23070 23101 +31
===========================================
+ Hits 22891 22921 +30
- Misses 179 180 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@rtimms Can you re-review this? |
Contributor
Author
|
@agriyakhetarpal Could your review this as well? It was approved before and the BPX parts pass tests already |
Member
|
Sure, I will do it tomorrow – thanks! |
rtimms
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BPX switched to Pydantic V2 and the switch causes some breaking changes in PyBaMM
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest(or$ nox -s tests)$ python -m pytest --doctest-plus src(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks: