Skip to content

Update BPX version and make PyBaMM compatible with Pydantic V2#4701

Merged
kratman merged 20 commits into
pybamm-team:developfrom
kratman:feat/updateBPX
Dec 27, 2024
Merged

Update BPX version and make PyBaMM compatible with Pydantic V2#4701
kratman merged 20 commits into
pybamm-team:developfrom
kratman:feat/updateBPX

Conversation

@kratman

@kratman kratman commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

Description

BPX switched to Pydantic V2 and the switch causes some breaking changes in PyBaMM

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman

kratman commented Dec 20, 2024

Copy link
Copy Markdown
Contributor Author

I expect this to fail until the new BPX release is available. I tested this locally with the BPX release candidate

rtimms
rtimms previously approved these changes Dec 20, 2024
@kratman kratman marked this pull request as ready for review December 20, 2024 18:46
@codecov

codecov Bot commented Dec 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (a7253b8) to head (b2163e6).
Report is 121 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4701      +/-   ##
===========================================
- Coverage    99.22%   99.22%   -0.01%     
===========================================
  Files          303      303              
  Lines        23070    23101      +31     
===========================================
+ Hits         22891    22921      +30     
- Misses         179      180       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kratman kratman added the release blocker Issues that need to be addressed before the creation of a release label Dec 23, 2024
@kratman

kratman commented Dec 23, 2024

Copy link
Copy Markdown
Contributor Author

@rtimms Can you re-review this?

@kratman

kratman commented Dec 26, 2024

Copy link
Copy Markdown
Contributor Author

@agriyakhetarpal Could your review this as well? It was approved before and the BPX parts pass tests already

@agriyakhetarpal

Copy link
Copy Markdown
Member

Sure, I will do it tomorrow – thanks!

@kratman kratman merged commit a362f92 into pybamm-team:develop Dec 27, 2024
@kratman kratman deleted the feat/updateBPX branch January 2, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release blocker Issues that need to be addressed before the creation of a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants