Skip to content

Add dt_min option for IDAKLUSolver#4736

Merged
MarcBerliner merged 2 commits into
developfrom
idaklu-add-dt-min
Jan 6, 2025
Merged

Add dt_min option for IDAKLUSolver#4736
MarcBerliner merged 2 commits into
developfrom
idaklu-add-dt-min

Conversation

@MarcBerliner

Copy link
Copy Markdown
Member

Description

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@MarcBerliner MarcBerliner marked this pull request as ready for review January 6, 2025 15:51
@kratman

kratman commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Tagging my PR so I make sure to include these changes #4487

@codecov

codecov Bot commented Jan 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (a7253b8) to head (c44ef14).
Report is 135 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4736      +/-   ##
===========================================
+ Coverage    99.22%   99.24%   +0.01%     
===========================================
  Files          303      303              
  Lines        23070    23242     +172     
===========================================
+ Hits         22891    23066     +175     
+ Misses         179      176       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcBerliner MarcBerliner merged commit 198fdb7 into develop Jan 6, 2025
@MarcBerliner MarcBerliner deleted the idaklu-add-dt-min branch January 6, 2025 17:32
@kratman kratman mentioned this pull request Jan 7, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants