add operator to experiment terminations#4770
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4770 +/- ##
========================================
Coverage 98.69% 98.69%
========================================
Files 303 303
Lines 23226 23256 +30
========================================
+ Hits 22923 22953 +30
Misses 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valentinsulzer
left a comment
There was a problem hiding this comment.
Good idea including this, do most cyclers ask for a direction or do they figure it out automatically?
Neware and Maccor, the only ones I've dealt with, have "charge" or "discharge" built into the steps and they also have these limits specified with operators. The reason for this is so that they can go to a "safer" state in case of a short or something. This of course is not relevant for pybamm, but there's not a great way to filter the safety limits without catching the other limits. |
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
|
this idaklu error doesn't look related to this pr |
Yeah it is a flaky test, not sure why that happens, but I have not really been able to reproduce it locally. Re-triggering it should make it pass. It is on my to-do list |
Description
Adds operator for experiment terminations. While this won't functionally change many experiments, it enables experiments to more closely mirror cell testing protocols.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest(or$ nox -s tests)$ python -m pytest --doctest-plus src(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks: