Skip to content

Adds support for particle size distributions combined with particle mechanics. - #4807

Merged
rtimms merged 9 commits into
pybamm-team:developfrom
aabills:psd-mechanics
Feb 3, 2025
Merged

Adds support for particle size distributions combined with particle mechanics.#4807
rtimms merged 9 commits into
pybamm-team:developfrom
aabills:psd-mechanics

Conversation

@aabills

@aabills aabills commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

self-descriptive.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov

codecov Bot commented Jan 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (c017be4) to head (adc092a).
Report is 95 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4807   +/-   ##
========================================
  Coverage    98.69%   98.70%           
========================================
  Files          303      303           
  Lines        23258    23312   +54     
========================================
+ Hits         22955    23009   +54     
  Misses         303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aabills
aabills marked this pull request as ready for review January 28, 2025 23:18
@aabills

aabills commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

test failure unrelated

Comment thread src/pybamm/models/submodels/particle_mechanics/base_mechanics.py Outdated
@aabills
aabills requested a review from kratman January 31, 2025 19:34
@rtimms
rtimms merged commit 04422b1 into pybamm-team:develop Feb 3, 2025
medha-14 pushed a commit to medha-14/PyBaMM that referenced this pull request Feb 3, 2025
…echanics. (pybamm-team#4807)

* add particle stress distribution variables

* add cracking

* add test

* fix tests and mpm issue

* coverage

* changelog

* changelog format

* eric comment

* fix test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants