Skip to content

Fix exponential mesh bug - #4989

Merged
kratman merged 3 commits into
developfrom
issue-4988
Apr 23, 2025
Merged

Fix exponential mesh bug#4989
kratman merged 3 commits into
developfrom
issue-4988

Conversation

@rtimms

@rtimms rtimms commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes a bug with Exponential1DSubMesh when the left edge is non-zero.

Fixes #4988

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms
rtimms requested a review from a team as a code owner April 23, 2025 10:58
@codecov

codecov Bot commented Apr 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (eb9f5fc) to head (071ffd8).
Report is 106 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4989   +/-   ##
========================================
  Coverage    98.62%   98.62%           
========================================
  Files          304      304           
  Lines        23755    23756    +1     
========================================
+ Hits         23428    23429    +1     
  Misses         327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcBerliner MarcBerliner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kratman
kratman merged commit 4f6430a into develop Apr 23, 2025
@kratman
kratman deleted the issue-4988 branch April 23, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Exponential1DSubMesh gives bad results

3 participants