Update docs, examples and tests to use IDAKLUSolver#4996
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4996 +/- ##
========================================
Coverage 98.57% 98.57%
========================================
Files 304 304
Lines 23656 23656
========================================
Hits 23320 23320
Misses 336 336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kratman
reviewed
Apr 25, 2025
kratman
left a comment
kratman
left a comment
Contributor
There was a problem hiding this comment.
Partial review. I will finish the reset later
kratman
reviewed
May 12, 2025
kratman
left a comment
kratman
left a comment
Contributor
There was a problem hiding this comment.
Minor stuff, most of the rest looks good
kratman
requested changes
May 13, 2025
kratman
left a comment
kratman
left a comment
Contributor
There was a problem hiding this comment.
One last change, then I will approve
kratman
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the default solver change to
IDAKLUSolver, this PR changes the examples, docs, and main tests to use theIDAKLUSolver. The one exception is the lead acid models, which do not work with theIDAKLUSolver.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests