Conversation
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
+ Coverage 98.44% 98.45% +<.01%
==========================================
Files 179 179
Lines 9896 9945 +49
==========================================
+ Hits 9742 9791 +49
Misses 154 154
Continue to review full report at Codecov.
|
valentinsulzer
left a comment
valentinsulzer
left a comment
There was a problem hiding this comment.
Cheers @rtimms , looks good to me
| \\beta = \\frac{\\Delta x_1}{\\Delta x_2 + \\Delta x_1} | ||
|
|
||
| accounts for the difference in the control volume widths. This is the | ||
| definiton from [1]. |
There was a problem hiding this comment.
is this the same definition as the Recktenwald paper?
There was a problem hiding this comment.
yeah, just in slightly different notation. Could remove this ref if you think it's cleaner to just provide one
There was a problem hiding this comment.
just saying it's the same but with different notation would be fine (you can add that commit with [ci skip] if you don't want to wait for the tests)
2 participants
Description
Adds the harmonic mean to the finite element method. This is then used in
process_binary_operatorsso that fluxes are computed using the harmonic mean of the diffusivity (or conductivity etc.)Fixes #782
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: