Repository navigation
Issue 830 algebraic - #868
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #868 +/- ##
===========================================
+ Coverage 97.70% 97.75% +0.04%
===========================================
Files 201 202 +1
Lines 10433 10459 +26
===========================================
+ Hits 10194 10224 +30
+ Misses 239 235 -4
Continue to review full report at Codecov.
|
rtimms
approved these changes
Mar 9, 2020
| # set it to 0 | ||
| if self.algebraic_solver is True and t_eval is None: | ||
| t_eval = np.array([0]) | ||
|
|
Contributor
There was a problem hiding this comment.
should we need to raise an error here if t_eval is None and the solver isn't algebraic?
2 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reformat algebraic solver to be more in line with the other solvers, and add casadi algebraic solver.
We could call the algebraic solvers to initialize the dae models, would reduce code duplication, but might be a little bit confusing?
Fixes #830
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: