New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README, Contributing, Internals #341

Merged
merged 7 commits into from Nov 6, 2016

Conversation

Projects
None yet
4 participants
@glasnt
Member

glasnt commented Oct 29, 2016

This adds the basic Getting Started guide to the README, removes a duplicate pun-reasoning, and other cleanups.

I'm still not 100% happy with it, but I think it's an improvement.

Note for self for later, pip install restview; restview <filename> makes for really nice RST previewing.

Show outdated Hide outdated README.rst
_ pybee
\_ batavia
\_ ouroboros
\_ venv

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

Will venv exist if you're using conda?

@freakboy3742

freakboy3742 Oct 29, 2016

Member

Will venv exist if you're using conda?

Show outdated Hide outdated README.rst
* For Linux, MacOS::
$ virtualenv venv

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

including a --pythonwhich python3`` would be a good idea here; most Linux/macOS machines don't do Py3 by default.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

including a --pythonwhich python3`` would be a good idea here; most Linux/macOS machines don't do Py3 by default.

Show outdated Hide outdated README.rst
* For Windows::
> virtualenv --python=c:\python34\python.exe env

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

s/env/venv/ at the end

@freakboy3742

freakboy3742 Oct 29, 2016

Member

s/env/venv/ at the end

Show outdated Hide outdated README.rst
Then, we need to create a virtual environment, and install Batavia into it.
* For Linux, MacOS::

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

macOS is uncapitalised in the official rendition.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

macOS is uncapitalised in the official rendition.

Show outdated Hide outdated README.rst
Getting a working local copy of Batavia requires a few steps: getting a copy of
the Batavia code, and the ouroboros dependency within a virtual environment.
You'll need to have Pyhton 3.4 available for Batavia to work. Instructions on

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

sp: Python 3.4

@freakboy3742

freakboy3742 Oct 29, 2016

Member

sp: Python 3.4

Show outdated Hide outdated README.rst
You'll need to have Pyhton 3.4 available for Batavia to work. Instructions on
how to set this up are `on our Environment setup guide
<http://pybee.org/contributing/first-time/setup/>`_.

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

Is the contributing guide the best place to point here? Do we need a separate "here's how to Python" guide?

@freakboy3742

freakboy3742 Oct 29, 2016

Member

Is the contributing guide the best place to point here? Do we need a separate "here's how to Python" guide?

This comment has been minimized.

@glasnt

glasnt Oct 29, 2016

Member

That link is the current 'how to setup pyenv, virtualenv' page.

@glasnt

glasnt Oct 29, 2016

Member

That link is the current 'how to setup pyenv, virtualenv' page.

Show outdated Hide outdated README.rst
\_ venv
You now have a working Batavia environment!

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

My impression: this is overly detailed for the README. To my mind, the README can stick to a very high level "get a Python 3.4 venv, and a checkout of batavia and ouroboros; it should look like this". If you need more details, point at the getting started guide.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

My impression: this is overly detailed for the README. To my mind, the README can stick to a very high level "get a Python 3.4 venv, and a checkout of batavia and ouroboros; it should look like this". If you need more details, point at the getting started guide.

Show outdated Hide outdated README.rst
Documentation for Batavia can be found on `Read The Docs`_, including:
* `So, why is it called "Batavia"? <https://batavia.readthedocs.io/en/latest/intro/faq.html#why-batavia>`_
* `More Frequently Asked Questions <https://batavia.readthedocs.io/en/latest/intro/faq.html>`_

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

+1 to these - do we want to add other hotlinks like "how do I contribute" - i.e., the other key calls to action that the project might have?

@freakboy3742

freakboy3742 Oct 29, 2016

Member

+1 to these - do we want to add other hotlinks like "how do I contribute" - i.e., the other key calls to action that the project might have?

This comment has been minimized.

@glasnt

glasnt Oct 29, 2016

Member

They sit at the bottom of the doc, so they might not be as visible, but I'll add a few if I think of any

@glasnt

glasnt Oct 29, 2016

Member

They sit at the bottom of the doc, so they might not be as visible, but I'll add a few if I think of any

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Minor markup thing: you need to strip the space before the bullet, or GitHub interprets it as a code sample.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Minor markup thing: you need to strip the space before the bullet, or GitHub interprets it as a code sample.

Show outdated Hide outdated README.rst
.. _Getting Started guide: https://batavia.readthedocs.io/en/latest/intro/getting-started.html
.. _the first tutorial: https://batavia.readthedocs.io/en/latest/tutorials/tutorial-0.html

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

In line with the previous comment: this shouldn't be listed as a tutorial - it's a quick start. "Get your venv, install dependencies, start runserver, poke around in the browser. For a more detailed walkthrough, see the tutorial."

@freakboy3742

freakboy3742 Oct 29, 2016

Member

In line with the previous comment: this shouldn't be listed as a tutorial - it's a quick start. "Get your venv, install dependencies, start runserver, poke around in the browser. For a more detailed walkthrough, see the tutorial."

This comment has been minimized.

@glasnt

glasnt Oct 29, 2016

Member

For a more detailed walkthrough, see the tutorial

This is a very good point (and sort of a 💡 moment for me). The tutorial should be the walkthrough. We should have a Quick Guide and a more Detailed Guide. A Tutorial is a good fit for the second version.

@glasnt

glasnt Oct 29, 2016

Member

For a more detailed walkthrough, see the tutorial

This is a very good point (and sort of a 💡 moment for me). The tutorial should be the walkthrough. We should have a Quick Guide and a more Detailed Guide. A Tutorial is a good fit for the second version.

Show outdated Hide outdated docs/intro/getting-started.rst
In this guide we will walk you through setting up your Batavia environment for
development and testing. We will assume that you have a working Python 3.4,
and use virtualenv.
_A copy of this documentation also appears in the Batavia `README <https://github.com/pybee/batavia#getting-started>`_

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 29, 2016

Member

Should it?

@freakboy3742

freakboy3742 Oct 29, 2016

Member

Should it?

This comment has been minimized.

@glasnt

glasnt Oct 29, 2016

Member

Not with your comments, no. Will change.

@glasnt

glasnt Oct 29, 2016

Member

Not with your comments, no. Will change.

@glasnt

This comment has been minimized.

Show comment
Hide comment
@glasnt

glasnt Oct 29, 2016

Member

Changes:

  • the full Getting Started is how Tutorial 0
  • the sandbox tute is bumped to Tutorial 1
  • misc spelling, syntax fixes
Member

glasnt commented Oct 29, 2016

Changes:

  • the full Getting Started is how Tutorial 0
  • the sandbox tute is bumped to Tutorial 1
  • misc spelling, syntax fixes
Show outdated Hide outdated README.rst
To take Batavia for a spin, run through the `Getting Started guide`_.
(For a more detailed setup, please see the `Getting Started tutorial <https://batavia.readthedocs.io/en/latest/tutorials/tutorial-0.html>`_

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Missing a closing bracket.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Missing a closing bracket.

Show outdated Hide outdated README.rst
Documentation for Batavia can be found on `Read The Docs`_, including:
* `So, why is it called "Batavia"? <https://batavia.readthedocs.io/en/latest/intro/faq.html#why-batavia>`_
* `More Frequently Asked Questions <https://batavia.readthedocs.io/en/latest/intro/faq.html>`_

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Minor markup thing: you need to strip the space before the bullet, or GitHub interprets it as a code sample.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Minor markup thing: you need to strip the space before the bullet, or GitHub interprets it as a code sample.

@@ -1,175 +1,65 @@
Tutorial 0 - Sandbox
====================
Tutorial 0 - Getting Started

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

What's the motivation between turning "getting started" into tutorial 0? Not necessarily disagreeing with the change, just interested in hearing your motivation.

My original thought was "getting started" is just getting ducks in a row; a tutorial should end with something that actually works or does something. Tutorial 0 isn't actually doing anything practical; it's just getting the sandbox running. Tutorial 1 is the first "actually do something useful" version.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

What's the motivation between turning "getting started" into tutorial 0? Not necessarily disagreeing with the change, just interested in hearing your motivation.

My original thought was "getting started" is just getting ducks in a row; a tutorial should end with something that actually works or does something. Tutorial 0 isn't actually doing anything practical; it's just getting the sandbox running. Tutorial 1 is the first "actually do something useful" version.

This comment has been minimized.

@glasnt

glasnt Oct 31, 2016

Member

Tutorials are the 'wordy' things. Having a step-by-step "here is how to setup pyenv, virtualenv, batavia" makes sense for a tutorial.

I bumped the Sandbox Tutorial to 1, because the GettingStarted is now 0. Given we don't have a 'actually do something useful' tutorial as yet, i'm not sure how else the numbering could work.

@glasnt

glasnt Oct 31, 2016

Member

Tutorials are the 'wordy' things. Having a step-by-step "here is how to setup pyenv, virtualenv, batavia" makes sense for a tutorial.

I bumped the Sandbox Tutorial to 1, because the GettingStarted is now 0. Given we don't have a 'actually do something useful' tutorial as yet, i'm not sure how else the numbering could work.

This comment has been minimized.

@glasnt

glasnt Nov 3, 2016

Member

Also, I didn't want to merge 0 and 1 together, because then the one tutorial would be too big.

@glasnt

glasnt Nov 3, 2016

Member

Also, I didn't want to merge 0 and 1 together, because then the one tutorial would be too big.

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

I recommend not using the term "tutorial" here because the content is actually generic so "getting started" is more appropriate. Normally, tutorials use an example scenario to show some real-world usage of software, so you'd have something like "Max and Jane want to build an app that makes sandwiches, here's how they did it". In this case, getting started is more accurate because it's basic setup and config steps without a specific use-case in mind.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

I recommend not using the term "tutorial" here because the content is actually generic so "getting started" is more appropriate. Normally, tutorials use an example scenario to show some real-world usage of software, so you'd have something like "Max and Jane want to build an app that makes sandwiches, here's how they did it". In this case, getting started is more accurate because it's basic setup and config steps without a specific use-case in mind.

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

And actually, to differentiate from the quick start, maybe you can rename this more accurately to describe the goal of the process, like "Basic installation and setup"?

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

And actually, to differentiate from the quick start, maybe you can rename this more accurately to describe the goal of the process, like "Basic installation and setup"?

Show outdated Hide outdated README.rst
Python in the Browser
----------------------
Once you've setup your environment, you can have some fun with `running Python in your browser <https://batavia.readthedocs.io/en/latest/tutorials/tutorial-1.html>`_

This comment has been minimized.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Should this be a separate heading, or just run into a couple more quick start commands - i.e.,

$ cd testserver
$ pip install -r requirements.txt
$ ./manage.py runserver

then open a web browser at localhost:8080.

@freakboy3742

freakboy3742 Oct 30, 2016

Member

Should this be a separate heading, or just run into a couple more quick start commands - i.e.,

$ cd testserver
$ pip install -r requirements.txt
$ ./manage.py runserver

then open a web browser at localhost:8080.

Show outdated Hide outdated README.rst
To take Batavia for a spin, run through the `Getting Started guide`_.
(For a more detailed setup, please see the `Getting Started tutorial <https://batavia.readthedocs.io/en/latest/tutorials/tutorial-0.html>`_)

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

Not sure whether starting a new section with a "see more" parentheses is best practice, usually this info should go at the end of the section as a regular paragraph. Alternatively, you can state the purpose of this section "Here's a high-level overview of what you need to do", followed by this sentence as a regular sentence in a paragraph.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

Not sure whether starting a new section with a "see more" parentheses is best practice, usually this info should go at the end of the section as a regular paragraph. Alternatively, you can state the purpose of this section "Here's a high-level overview of what you need to do", followed by this sentence as a regular sentence in a paragraph.

Show outdated Hide outdated README.rst
.. _Getting Started guide: https://batavia.readthedocs.io/en/latest/intro/getting-started.html
.. _the first tutorial: https://batavia.readthedocs.io/en/latest/tutorials/tutorial-0.html
Clone the code repos::

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

you can use numbered lists for this, easier skimming

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

you can use numbered lists for this, easier skimming

Show outdated Hide outdated README.rst
$ make
Python in the Browser

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

it looks like there's a mismatch of the title and the section content, maybe rephrase as an action or goal like "Running Batavia in the browser", and then adjust the intro sentence to reflect the purpose of this section (because it's separate from the "quick start" part). Maybe say something like "After you set up, you can view the results in a browser..." etc.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

it looks like there's a mismatch of the title and the section content, maybe rephrase as an action or goal like "Running Batavia in the browser", and then adjust the intro sentence to reflect the purpose of this section (because it's separate from the "quick start" part). Maybe say something like "After you set up, you can view the results in a browser..." etc.

@@ -32,21 +32,49 @@ Javascript. With Batavia, you can run Python bytecode in your browser.
It honors Python 3.4.4+ syntax and conventions, and let's you
reference objects and classes defined natively in JavaScript.
Tutorial
--------
Quick Start

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

recommendation - create sub-headings for Prerequisites (python 3.4 etc), Downloading and Installing, and Accessing/Viewing (this already has a heading "python in the browser"), for easier skimming/chunking.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

recommendation - create sub-headings for Prerequisites (python 3.4 etc), Downloading and Installing, and Accessing/Viewing (this already has a heading "python in the browser"), for easier skimming/chunking.

Show outdated Hide outdated README.rst
$ pip install -r requirements.txt
$ ./manage.py runserver
then open a web browser at localhost:8080.
Documentation

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor
  • Make "Documentation for Batavia" act as the hyperlink to the root directoy of the RTD library (instead of "Ready the Docs")
  • There seem to be a lot more sections in the RTD library, maybe consider listing the highest-level toc entries (like tutorials, how-to guide, etc).
@thatdocslady

thatdocslady Nov 5, 2016

Contributor
  • Make "Documentation for Batavia" act as the hyperlink to the root directoy of the RTD library (instead of "Ready the Docs")
  • There seem to be a lot more sections in the RTD library, maybe consider listing the highest-level toc entries (like tutorials, how-to guide, etc).
Show outdated Hide outdated README.rst
`shipwrecks gallery of the Western Australian Maritime Museum`_.
.. _full story of the Batavia: https://en.wikipedia.org/wiki/Batavia_(ship)
.. _shipwrecks gallery of the Western Australian Maritime Museum: http://museum.wa.gov.au/museums/shipwrecks
Issues

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

recommendation - rename "issues" to "contributing" or "join the community" or some other clickbaity goodness :)

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

recommendation - rename "issues" to "contributing" or "join the community" or some other clickbaity goodness :)

Show outdated Hide outdated README.rst
$ git clone https://github.com/pybee/batavia
$ git clone https://github.com/pybee/ouroboros
Setup a virtualenv (for other environments, see `Getting Started <https://batavia.readthedocs.io/en/latest/tutorials/tutorial-0.html>`_)::

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

I followed the link for other environments and then got a bit lost because the link is to the root of the tutorial, if there's a way to painlessly semi-deep-link to a relative path of the section that describes the environments or something similar, it would be helpful.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

I followed the link for other environments and then got a bit lost because the link is to the root of the tutorial, if there's a way to painlessly semi-deep-link to a relative path of the section that describes the environments or something similar, it would be helpful.

Show outdated Hide outdated docs/internals/contributing.rst
@@ -46,6 +46,7 @@ Then create a virtual environment and install Batavia into it:
*For those using anaconda*:

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

General review:

  • "Setting up dev env" - numbered lists could be useful for skimming/chunking, and it'll spare the usage of "then,", "after that", "lastly", and other redundant text.
  • Are the OS-specific steps supposed to be performed after you set up the dev env, and only choose one of them? if so, maybe it's better to group them under a single heading with a purpose stated like "Download and install PhantomJS" (it seems like most of these describe how to do that).
@thatdocslady

thatdocslady Nov 5, 2016

Contributor

General review:

  • "Setting up dev env" - numbered lists could be useful for skimming/chunking, and it'll spare the usage of "then,", "after that", "lastly", and other redundant text.
  • Are the OS-specific steps supposed to be performed after you set up the dev env, and only choose one of them? if so, maybe it's better to group them under a single heading with a purpose stated like "Download and install PhantomJS" (it seems like most of these describe how to do that).
to run this code. It's not overly concerning, though, as the main
use case here is basic DOM manipulation and responding to button clicks, not
heavy computation.
Next, we can `setup the sandbox </tutorials/tutorial-1>`, and try out

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

link to the next tutorial is broken/non-existent?

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

link to the next tutorial is broken/non-existent?

This comment has been minimized.

@glasnt

glasnt Nov 5, 2016

Member

This link won't work until the tutorial-1.rst file is committed.

@glasnt

glasnt Nov 5, 2016

Member

This link won't work until the tutorial-1.rst file is committed.

Show outdated Hide outdated docs/tutorials/tutorial-0.rst
This tutorial assumes you've read and followed the instructions in
:doc:`/intro/getting-started`. If you've done this, you should have:
Setup a `pybee` folder to store everything::

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

numbered lists FTW :D

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

numbered lists FTW :D

Show outdated Hide outdated docs/tutorials/tutorial-1.rst
@@ -0,0 +1,175 @@
Tutorial 1 - Sandbox

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor
  • in this case the term "tutorial" is actually more accurate because the goal is to set up and run a sample hello world application, which users might not necessarily need but acts as an example workflow
  • generally for task-oriented topics it's better to name titles to reflect the action/goal like "Deploying a Hello World application in the Batavia Sandbox" or something less wordy :)
@thatdocslady

thatdocslady Nov 5, 2016

Contributor
  • in this case the term "tutorial" is actually more accurate because the goal is to set up and run a sample hello world application, which users might not necessarily need but acts as an example workflow
  • generally for task-oriented topics it's better to name titles to reflect the action/goal like "Deploying a Hello World application in the Batavia Sandbox" or something less wordy :)
Show outdated Hide outdated docs/tutorials/tutorial-1.rst
In this tutorial, you'll get the Batavia sandbox running, and use it to run a
really simple "Hello, world!" program written in Python.
Setup

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

can rename this to prerequisites?

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

can rename this to prerequisites?

Show outdated Hide outdated docs/tutorials/tutorial-1.rst
Starting the test server
------------------------
To start the test server, you'll need to be in the ``testserver`` directory under the batavia directory::

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

numbered lists, numbered lists everywhere :D

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

numbered lists, numbered lists everywhere :D

Show outdated Hide outdated docs/tutorials/tutorial-1.rst
.. _BeeWare website: http://pybee.org
If you want to, you can `inspect the source code`_. One part of

This comment has been minimized.

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

is this section related to the "push the button section", or a separate task? maybe separate into a standalone section with a heading

@thatdocslady

thatdocslady Nov 5, 2016

Contributor

is this section related to the "push the button section", or a separate task? maybe separate into a standalone section with a heading

@doismellburning

This comment has been minimized.

Show comment
Hide comment
@doismellburning

doismellburning Nov 5, 2016

Contributor

Ooh this is awesome, sorry I didn't see this before I filed #352! I'll happily base mine on this if it helps.

Contributor

doismellburning commented Nov 5, 2016

Ooh this is awesome, sorry I didn't see this before I filed #352! I'll happily base mine on this if it helps.

@glasnt

This comment has been minimized.

Show comment
Hide comment
@glasnt

glasnt Nov 5, 2016

Member

oh my gosh thank you @thatdocslady for such a thorough review!

I'll fixed up these things before y'all get back to sprinting tomorrow (I'm UTC+11, so.. timezones 😄)

Member

glasnt commented Nov 5, 2016

oh my gosh thank you @thatdocslady for such a thorough review!

I'll fixed up these things before y'all get back to sprinting tomorrow (I'm UTC+11, so.. timezones 😄)

@glasnt

This comment has been minimized.

Show comment
Hide comment
@glasnt

glasnt Nov 5, 2016

Member

Ok, a bunch of changes have been made, thanks to Mikey's review.

I'm still keeping the wordy-walkthroughts as URLs named tutorial-X, but the titles of these docs have changed. Also since the shifting of tutorial numbers, the links won't work until these docs are committed (tutorial-0 is now tutorial-1, etc)

To get the other issues/PRs from @thatdocslady and @doismellburning unblocked, feel free to merge this and correct issues in another PR. Timezones, etc. Enjoy #DUTH!

Member

glasnt commented Nov 5, 2016

Ok, a bunch of changes have been made, thanks to Mikey's review.

I'm still keeping the wordy-walkthroughts as URLs named tutorial-X, but the titles of these docs have changed. Also since the shifting of tutorial numbers, the links won't work until these docs are committed (tutorial-0 is now tutorial-1, etc)

To get the other issues/PRs from @thatdocslady and @doismellburning unblocked, feel free to merge this and correct issues in another PR. Timezones, etc. Enjoy #DUTH!

@thatdocslady

This comment has been minimized.

Show comment
Hide comment
@thatdocslady

thatdocslady Nov 6, 2016

Contributor

Awesome @glasnt !!! Looks great, ship it :)

Contributor

thatdocslady commented Nov 6, 2016

Awesome @glasnt !!! Looks great, ship it :)

@glasnt

This comment has been minimized.

Show comment
Hide comment
@glasnt

glasnt Nov 6, 2016

Member

Have rebased, should be good as soon as @freakboy3742 gives the all clear

Member

glasnt commented Nov 6, 2016

Have rebased, should be good as soon as @freakboy3742 gives the all clear

@freakboy3742 freakboy3742 merged commit cbf1e5b into master Nov 6, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@glasnt glasnt deleted the topic/readme branch Dec 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment