New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Bool.js, change default for JSCleaner #566

Merged
merged 2 commits into from Jun 11, 2017

Conversation

Projects
None yet
2 participants
@abonie
Contributor

abonie commented Jun 9, 2017

Bug in bool comparisons caused bool/float comparisons to return float.

Default behaviour of assertCodeExecution was to capitalize lowercase
occurences of "true" and "false" in output, which seems to serve no
purpose, but silence the above mentioned bug, and cause tests like
assertCodeExecution("print('true')") to fail.

Also very minor changes to ModuleFunctionTestCase including fixing
misspelled method name.

@abonie abonie force-pushed the abonie:test_utils branch from 6d2a977 to 651846b Jun 9, 2017

Fix bug in Bool.js, change default for JSCleaner
Bug in bool comparisons caused bool/float comparisons to return float.

Default behaviour of assertCodeExecution was to capitalize lowercase
occurences of "true" and "false" in output, which seems to serve no
purpose, but silence the above mentioned bug, and cause tests like
`assertCodeExecution("print('true')")` to fail.

Also very minor changes to ModuleFunctionTestCase including fixing
misspelled method name.

@abonie abonie force-pushed the abonie:test_utils branch from 651846b to a1b9210 Jun 10, 2017

@freakboy3742

Good catch! 🐟

@freakboy3742 freakboy3742 merged commit 9ebacd1 into pybee:master Jun 11, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment