New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with cricket and invalid test names #589

Merged
merged 1 commit into from Jul 15, 2017

Conversation

Projects
None yet
3 participants
@abonie
Contributor

abonie commented Jul 8, 2017

An attempt to fix issue described here: #588

@jmsdvl

This comment has been minimized.

Show comment
Hide comment
@jmsdvl

jmsdvl Jul 8, 2017

This fixes the errors with cricket trying to load the JSONEncoder tests, but now all the tests in StdlibTests are failing from tests/utils.py:445 with some variant on:

AssertionError: 'Unknown opcode 0 (<0>)\n' != 'Done\n'
- Unknown opcode 0 (<0>)
+ Done

Where done is just the expected output for this test (test_operator in this case).

jmsdvl commented Jul 8, 2017

This fixes the errors with cricket trying to load the JSONEncoder tests, but now all the tests in StdlibTests are failing from tests/utils.py:445 with some variant on:

AssertionError: 'Unknown opcode 0 (<0>)\n' != 'Done\n'
- Unknown opcode 0 (<0>)
+ Done

Where done is just the expected output for this test (test_operator in this case).

@abonie

This comment has been minimized.

Show comment
Hide comment
@abonie

abonie Jul 9, 2017

Contributor

@jmsdvl Are you sure no other changes affected this outcome? It's either that, or some issue with cricket I have no idea how to deal with right now. Could you try and run tests from command line e.g. python setupy.py test -s tests/modules/test_stdlib.py? I get no failures then, and also I don't see how these changes could affect StdlibTests at all.

Contributor

abonie commented Jul 9, 2017

@jmsdvl Are you sure no other changes affected this outcome? It's either that, or some issue with cricket I have no idea how to deal with right now. Could you try and run tests from command line e.g. python setupy.py test -s tests/modules/test_stdlib.py? I get no failures then, and also I don't see how these changes could affect StdlibTests at all.

@jmsdvl

This comment has been minimized.

Show comment
Hide comment
@jmsdvl

jmsdvl Jul 9, 2017

I don't see how these changes could affect StdlibTests at all

@abonie I don't see how either. I re-ran the tests in a new, clean environment this morning and all tests pass. I have no idea what was causing the failures - no other source code was changed (according to git at least), and I was seeing the failures both from cricket and python setup.py test. But not now ಠ_ಠ

Looks like this is a good patch then.

jmsdvl commented Jul 9, 2017

I don't see how these changes could affect StdlibTests at all

@abonie I don't see how either. I re-ran the tests in a new, clean environment this morning and all tests pass. I have no idea what was causing the failures - no other source code was changed (according to git at least), and I was seeing the failures both from cricket and python setup.py test. But not now ಠ_ಠ

Looks like this is a good patch then.

@freakboy3742 freakboy3742 merged commit 4d8fd95 into pybee:master Jul 15, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment