Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix issue with cricket and invalid test names #589
referenced this pull request
Jul 8, 2017
This fixes the errors with cricket trying to load the JSONEncoder tests, but now all the tests in
Where done is just the expected output for this test (
@jmsdvl Are you sure no other changes affected this outcome? It's either that, or some issue with cricket I have no idea how to deal with right now. Could you try and run tests from command line e.g.
@abonie I don't see how either. I re-ran the tests in a new, clean environment this morning and all tests pass. I have no idea what was causing the failures - no other source code was changed (according to
Looks like this is a good patch then.