New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YIELD_FROM for Python 3.6+ #646

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
2 participants
@abonie
Contributor

abonie commented Aug 22, 2017

At the end of executing YIELD_FROM opcode instruction counter is
decremented to point at the previous instruction. Since Python 3.6 is
using 2-byte opcodes we have to decrement instruction counter by 2.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct
Fix YIELD_FROM for Python 3.6+
At the end of executing YIELD_FROM opcode instruction counter is
decremented to point at the previos instruction. Since Python 3.6 is
using 2-byte opcodes we have to decrement instruction counter by 2.

@phildini phildini merged commit 439bebf into pybee:master Aug 23, 2017

5 checks passed

beekeeper:0/beefore:eslint JavaScript lint checks passed.
Details
beekeeper:0/beefore:pycodestyle Python lint checks passed.
Details
beekeeper:1/smoke-test Smoke build (Python 3.4) passed.
Details
beekeeper:2/full-test:py3.5 Python 3.5 tests: non-critical problem found. Click for details.
Details
beekeeper:2/full-test:py3.6 Python 3.6 tests: non-critical problem found. Click for details.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment