This repository has been archived by the owner on May 31, 2020. It is now read-only.
Added powers of complex numbers #753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that 5th-order rounding differences between Python and Javascript don't fail the tests.
|
It seems that the smoke-test failure is related to the test environment and not to the PR. |
|
Thanks @shaib for getting this PR to this point! I took your branch here and got the tests happy with it and updated against the current master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #485 -- I have rebased it, squashed it into 2 commits, and then added my own commits to fix the behavior where I found it to be wrong.
This also includes an improvement to the test infrastructure, to make it compare floats and complex numbers in approximation.
PR Checklist: