New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for spaces in app name. Issue #2 #3

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Ocupe

Ocupe commented Jul 28, 2017

Changed absolute import to a relative one. This makes the working of the app independent from the package name.

@Ocupe

This comment has been minimized.

Show comment
Hide comment
@Ocupe

Ocupe Aug 4, 2017

@freakboy3742 With the new changes it is possible to run the app also as a module as well as a package. I think this gives people the choice to run the app in both ways. I also had problems to debug a app that runs as a package.

Ocupe commented Aug 4, 2017

@freakboy3742 With the new changes it is possible to run the app also as a module as well as a package. I think this gives people the choice to run the app in both ways. I also had problems to debug a app that runs as a package.

@craiglabenz

This comment has been minimized.

Show comment
Hide comment
@craiglabenz

craiglabenz May 14, 2018

Contributor

I think it'd be stronger to prevent modules with spaces outright. Cookiecutter now by default includes a pre-build hook to prevent such names, which I've backported forbriefcase-template's uses in #8.

Contributor

craiglabenz commented May 14, 2018

I think it'd be stronger to prevent modules with spaces outright. Cookiecutter now by default includes a pre-build hook to prevent such names, which I've backported forbriefcase-template's uses in #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment