New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/show widget [Core] [Cocoa] #184

Merged
merged 2 commits into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@Dayof
Contributor

Dayof commented Jun 25, 2017

Resolves Issue #181

@phildini

This comment has been minimized.

Show comment
Hide comment
@phildini

phildini Jun 26, 2017

Hey there! Would you consider this ready for review, or are you still working on it?

phildini commented Jun 26, 2017

Hey there! Would you consider this ready for review, or are you still working on it?

@Dayof

This comment has been minimized.

Show comment
Hide comment
@Dayof

Dayof Jun 26, 2017

Contributor

I think that can be reviewed. Later, this feature can be update with the addition of the constraints update on Cocoa.

Contributor

Dayof commented Jun 26, 2017

I think that can be reviewed. Later, this feature can be update with the addition of the constraints update on Cocoa.

Show outdated Hide outdated src/core/toga/interface/widgets/base.py Outdated
Show outdated Hide outdated src/cocoa/toga_cocoa/widgets/base.py Outdated
Show outdated Hide outdated src/cocoa/toga_cocoa/widgets/base.py Outdated
@phildini

This comment has been minimized.

Show comment
Hide comment
@phildini

phildini Jun 26, 2017

It would be really thrilling to see anything that looks like a test or example code for this.

phildini commented Jun 26, 2017

It would be really thrilling to see anything that looks like a test or example code for this.

@Dayof

This comment has been minimized.

Show comment
Hide comment
@Dayof

Dayof Jun 27, 2017

Contributor

I'll commit the new demands and post a code as an example. Thanks for the review @phildini and @freakboy3742 !

Contributor

Dayof commented Jun 27, 2017

I'll commit the new demands and post a code as an example. Thanks for the review @phildini and @freakboy3742 !

@freakboy3742

This comment has been minimized.

Show comment
Hide comment
@freakboy3742

freakboy3742 Jun 27, 2017

Member

@phildini The work @Ocupe is doing for the GSoC is aimed at making the Toga interface testable; hopefully we'll be able to add tests in the very near future.

Member

freakboy3742 commented Jun 27, 2017

@phildini The work @Ocupe is doing for the GSoC is aimed at making the Toga interface testable; hopefully we'll be able to add tests in the very near future.

@Dayof

This comment has been minimized.

Show comment
Hide comment
@Dayof
Contributor

Dayof commented Jun 27, 2017

@Dayof

This comment has been minimized.

Show comment
Hide comment
@Dayof

Dayof Jul 10, 2017

Contributor

@freakboy3742 @phildini @eliasdorneles does this PR still with some reviews to do?

Contributor

Dayof commented Jul 10, 2017

@freakboy3742 @phildini @eliasdorneles does this PR still with some reviews to do?

@freakboy3742

🚢

@freakboy3742 freakboy3742 merged commit 1e32c3a into pybee:master Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment