Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow "none" values for Choices when included in constants and/or string is an allowable type #6
This is a more robust approach to resolving #3.
What I'm proposing and showing here is that, instead of converting
This passes all unit tests.
referenced this pull request
Jul 22, 2018
freakboy3742 left a comment
I'm not convinced this is the right approach. We need to be very clear about the distinction between
The current code (and tests) are a bit loose, and lean towards coercing
Pack does this the right way - defining a constant
I did some more research on this.
If we need to distinguish between Python's
If we need a workaround, I think a magic
when setting up the constant, then
so that could be useful. Magic can be bad, but if we need this functionality, this workaround might be worth it. I've confirmed this approach works on versions 2.7 and 3.6.
So, we will need to differentiate the symbolic