Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added support for Yield from statement #821
This looks like a good first pass, and it's clearly got the basics working - good work!
However, this code doesn't cover all the error conditions that PEP380 covers. PEP380 includes branches for GeneratorExit, StopIteration including a value, and so on.
This might be something that you'll be able to tackle once you've got
send() and the other generator methods implemented - is that correct?
In cases like this where there is known "missing" functionality, it can help to either (a) include comments in the code that flag where "extra" logic will come later (e.g.,
# TODO: handle GeneratorError); and/or add tests for the edge cases you know are problematic (and then mark them as
@expectedFailure, possibly also with a comment). That way, you can signal to a reviewer that you've thought of the edge cases, you just haven't addressed them all yet.