New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Method repr() #837

Merged
merged 27 commits into from Jun 15, 2018

Conversation

Projects
None yet
6 participants
@patiences
Contributor

patiences commented Jun 11, 2018

While debugging I came across lines like:

- Comparator: <bound method null.__eq__ of test>

Kept me on the wrong trail for a bit. Turns out org.python.types.Type objects on org.python.types.Methods don't have a __name__ registered. This change uses org.python.types.Type's repr method, resulting in logs like:

- Comparator: <bound method <class 'str'>.__eq__ of test>

AmirYalamov and others added some commits Jun 1, 2018

Use python requires to require Python 3.4
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Revert back to allowing Python 3.4 or later
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Merge pull request #836 from BPYap/convert-bool-contruction-to-get-bool
Changed Bool construction to use getBool instead
Merge pull request #826 from AmirYalamov/test_tuple_fix
Fix test_set issues for test suite
Merge pull request #829 from danyeaw/python-requires
Use python requires to require Python 3.4
@eliasdorneles

This comment has been minimized.

Member

eliasdorneles commented Jun 13, 2018

Any idea why compilation failed in the CI?

@patiences

This comment has been minimized.

Contributor

patiences commented Jun 13, 2018

@eliasdorneles Ah, yes -- those failures have since been fixed in #836. I'm not sure how to retrigger the build?

@eliasdorneles

This comment has been minimized.

Member

eliasdorneles commented Jun 13, 2018

@patiences gotcha! So, if you synchronize the branch of this PR with master (either with merge or rebase), it will incorporate those changes and trigger a new build.

@freakboy3742

👍

@freakboy3742 freakboy3742 merged commit aa4e0ff into pybee:master Jun 15, 2018

5 checks passed

beekeeper:0/beefore:javacheckstyle Java lint checks passed.
Details
beekeeper:0/beefore:pycodestyle Python lint checks passed.
Details
beekeeper:1/smoke-test Smoke build (Python 3.4) passed.
Details
beekeeper:2/full-test:py3.5 Python 3.5 tests passed.
Details
beekeeper:2/full-test:py3.6 Python 3.6 tests passed.
Details

@patiences patiences deleted the patiences:fix-method-repr branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment