Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep cmake_example and python_example in sync as much as possible #4

Closed
SylvainCorlay opened this issue Jun 7, 2016 · 3 comments
Closed

Comments

@SylvainCorlay
Copy link
Member

I think that it would be beneficial to keep the two projects in sync as much as possible (directory structure, conda recipe). I imagine that if someone solves an issue for one, it will apply to the other if it is not cmake of distutils.compiler - specific.

I don't have a strong opinion of these matters (except that we should probably rename python_example/py to python_example/src like in cmake_example).

@dean0x7d
Copy link
Member

dean0x7d commented Jun 7, 2016

I agree. On the cmake_example side, the main.cpp file should be updated to match the one from python_example. With the docstrings in place, the sphinx docs folder could also be added.

In the other direction, if you are open to it, I believe that the .travis.yml and .appveyor.yml files from cmake_example could be added to python_example. The installation procedures are identical so the CI configs would not require any changes. Although, those only test pip install, since I haven't gotten around to setting up Travis and AppVeyor for the conda recipe. But I'd like to include a test for that as well.

There is a little bit of divergence with regard to Windows: because CMake will internally pick the latest VS version and set the environment appropriately, there is no need to manually call vcvarsall.bat. I assume this would also be the case for the conda recipe in cmake_example, so those lines probably can be removed. But as I said, I have not yet gotten around to testing this.

@SylvainCorlay
Copy link
Member Author

I agree. On the cmake_example side, the main.cpp file should be updated to match the one from python_example. With the docstrings in place, the sphinx docs folder could also be added.

👍

In the other direction, if you are open to it, I believe that the .travis.yml and .appveyor.yml files from cmake_example could be added to python_example. [...]

Yes, that is a good idea.

There is a little bit of divergence with regard to Windows: because CMake will internally pick the latest VS version and set the environment appropriately, there is no need to manually specify vcvarsall.bat. [...]

Interesting.

@dean0x7d
Copy link
Member

The projects should be in sync now with the bulk of the changes in #5 and pybind/python_example#14.
I don't expect any huge changes in the future, so the sync should be easy to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants