Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_include for nonstandard prefixes #1426

Closed
wants to merge 1 commit into from

Conversation

knedlsepp
Copy link

This fixes #1425.

@knedlsepp knedlsepp force-pushed the fix-get_include branch 3 times, most recently from b8c00c5 to ef358a2 Compare June 8, 2018 11:58
@anntzer
Copy link
Contributor

anntzer commented Feb 14, 2019

@knedlsepp Perhaps the correct solution is to locate the header relative to the actual installation, using e.g. https://importlib-metadata.readthedocs.io/en/latest/ (which will move to the stdlib in Py3.7)?
Does something like

header, = (file for file in importlib_metadata.files("pybind11")
           if file.name == "pybind11.h")
header.locate().resolve().parents[1]

print the correct include path for your setup?

@knedlsepp knedlsepp changed the title Fix get_include for nonstandard installations Fix get_include for nonstandard prefixes Mar 6, 2019
@henryiii
Copy link
Collaborator

This was fixed, see issue.

@henryiii henryiii closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_include returns incorrect directory for custom prefixes
3 participants